Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove testing of manual pipeline with iree-opt #978

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

newling
Copy link
Contributor

@newling newling commented Dec 10, 2024

Updating this test is causing issues, and I'd rather remove it than maintain it. The problem I hit is about an unregistered aievec pipeline. @Yu-Zhewen is hitting an error about 'memref.cast' op is an unsupported operation. We can probably figure this out with some time, but I'm not sure it's worth it?

@yzhang93
Copy link
Contributor

Updating this test is causing issues, and I'd rather remove it than maintain it. The problem I hit is about an unregistered aievec pipeline. @Yu-Zhewen is hitting an error about 'memref.cast' op is an unsupported operation. We can probably figure this out with some time, but I'm not sure it's worth it?

About unregistered aievec pipeline, you probably should pass flag --allow-unregistered-dialect .

Copy link
Collaborator

@jtuyls jtuyls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All right, I thought this was useful to be able to run and debug partial pipelines, but I haven't needed it a while, so if this causes issues in maintaining, I am ok removing it entirely.

@jtuyls jtuyls merged commit e954a73 into nod-ai:main Dec 11, 2024
7 checks passed
@newling newling deleted the remove_manual_pipeline_test branch December 12, 2024 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants